#5 ✓hold
Dovadi

Profile controller test is dependent on "Lovd by Less ..."

Reported by Dovadi | May 19th, 2008 @ 03:28 PM

Assert_match in profile controller test (line 41) fails if you change SITE_NAME.

Patch added with fix

Comments and changes to this ticket

  • Steven Bristol

    Steven Bristol September 25th, 2008 @ 04:02 PM

    I'm not sure I understand your ticket. It seems like the patch will break the test. Can you give more information?

  • Dovadi

    Dovadi September 25th, 2008 @ 04:37 PM

    My patch was from the 19th of May and I see it was fixed on the 21th of May by Dustin Schneider.

    See http://github.com/stevenbristol/...

    The issue was that if you changed the global variable SITE_NAME, the test failed because the site name lovd_by_less was hard coded in the test.

    So it was already resolved, although I'm not sure why my patch breaks the test....

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

People watching this ticket

Attachments

Pages